lochmueller / language_detection

🌎 Coolest TYPO3 language detection 🌎
14 stars 6 forks source link

MaxMind integration does not allow to override user language like GeoPluginDetect #33

Closed websi closed 1 year ago

websi commented 2 years ago

The MaxMind detect implementation does not allow to prepend or replace the user language from the browser.

https://github.com/lochmueller/language_detection/blob/99577353cf99b0bff3504322e32852b59b6c3436/Classes/Detect/MaxMindDetect.php#L46

The third parameter of "addLocaleByMode" is not used.

lochmueller commented 2 years ago

Hey @websi , I think you mean the configuration "addIpLocationToBrowserLanguage", right? This configuration is only for the detection via geoplugin.net and control also the enabled (one of the three options) / disabled (none) state. So this could not the same for the MaxMind detection. I suggest adding a new configuration like "languageDetectionMaxMindMode" with the three options to handle the configuration for MaxMind? Would you send a PR?

Regards, Tim