Closed chewiebug closed 5 years ago
Thanks a lot... i will merge this and create issues for the "package updates". I will check this in the next days.... 👍
Thank you very much!
-------- Original Message -------- From: Tim notifications@github.com Sent: 28 January 2019 22:36:17 CET To: lochmueller/perfectlightbox perfectlightbox@noreply.github.com Cc: chewiebug gcviewer@gmx.ch, Author author@noreply.github.com Subject: Re: [lochmueller/perfectlightbox] update extension to use jquery 2.2.4 + latest versions of slimbox2 / lightbox (#14)
Thanks a lot... i will merge this and create issues for the "package updates". I will check this in the next days.... 👍
-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/lochmueller/perfectlightbox/pull/14#issuecomment-458310992
I haven't tested this code after rebasing it on top of your master. My version has been in use on my homepage for a little more than a year.
There are a few things that probably should be addressed before the pull request is really good:
Well, that's what's in this branch.