search

lochstar / nativescript-cast

NativeScript Chromecast Plugin.
Apache License 2.0
16 stars 4 forks source link

Expanded controller #9

Closed jcarolus closed 5 years ago

jcarolus commented 5 years ago

The mini controller was causing some headache, so for now this seems a good improvement. It's not clear to me why it won't show images from metadata - the documentation on this is vague.

jcarolus commented 5 years ago

Just discovered it crashes on Android after a while. Also not happy with imlementation. Will be continued...

jcarolus commented 5 years ago

The crash should be fixed by the change to AndroidManifest. It's indeed code formatting default of my editor, so added those spaces back.

jcarolus commented 5 years ago

@lochstar I have added demo/webpack.config.js to the repository, it needed to be upgraded for latest nativescript and it's convenient to have the changes for Android in there anyway. A bit in doubt if it should be in the repo (the plugin template exludes it as well), but it does need some editing. What is your opinion?

edit: ./node_modules/.bin/update-ns-webpack --configs could also be added to README.

lochstar commented 5 years ago

@lochstar I have added demo/webpack.config.js to the repository,

Ouch it's meant to be there but has been ignored by the the .gitignore rule *.js. I'll get it fixed up.

jcarolus commented 5 years ago

@lochstar another small issue; the image did not show up because the image in the metadata https://d1u5p3l4wpay3k.cloudfront.net/lolesports_gamepedia_en/2/24/Space_eSportslogo_square.png?version=1352e7508b7e001da75af441b9221997 is no longer reachable. Perhaps also a via github.io hosted image?

So in my opinion ready to merge :) !

lochstar commented 5 years ago

Good stuff!