search

locie / pySIP

Stochastic state-space Inference and Prediction
14 stars 12 forks source link

lambda (anonymous function) in code disallow correct pickling for multiprocess #5

Closed celliern closed 4 years ago

celliern commented 4 years ago

Hello !

I'm trying to run pySIP with a distributed backend which is compatible with joblib. I have gone through pickling error. On a local copy of pySIP, I noticed the presence of lambda function in the library core that lead to pickling errors.

I can do a pull request with extra tests to make pySIP more robust to pickling which should improve the compatibility with multiprocessing and distributed computation.

mjanv commented 4 years ago

Thanks for the update. Needs to check with the test suite, but the pull requests seems good.

celliern commented 4 years ago

Oh, I forgot to say that I ran pytest before doing the pull request!

Le dim. 2 févr. 2020 à 11:52, Maxime Janvier notifications@github.com a écrit :

Thanks for the update. Needs to check with the test suite, but the pull requests seems good.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/locie/pySIP/issues/5?email_source=notifications&email_token=AAUPGFASCLB4WCGL4P3FXW3RA2QXVA5CNFSM4KOSTHX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKRTZSA#issuecomment-581123272, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUPGFAWSKGWHFRPHPVCJSLRA2QXVANCNFSM4KOSTHXQ .

LoicRaillon commented 4 years ago

I did the update on the Gitlab which is a couple of commits ahead of the Github. Everything is fine, we can push a new tag on the Github. We will be soon switching the development to the Github, thanks for the PR !