search

lociii / jukebox

Democratic Jukebox - your democratic music player
MIT License
300 stars 62 forks source link

Do files with missing ID3 data need to be skipped ? #41

Closed parthlawate closed 10 years ago

parthlawate commented 10 years ago

Hi,

I think looking at the indexer output that files having missing ID3 data are skipped. Is this really necessary ? can they not be added with filename as that data when getting added in the DB ?

lociii commented 10 years ago

They could for sure be added to the database. But you'll lose all advantages of indexing the songs. You won't be able to search for artist/title/genre etc. That's not acceptable for me.

parthlawate commented 10 years ago

true :) how about adding a flag in the indexer that lets you do that if you want to ? If you could point me where to look i could attempt that pull request ! Great job on this by the way ! Totally rocks !

I have this running on a headless raspberry pi.. Anyway to have the server start as a daemon ? cause the way its now, i cant write a script to boot it on stratup

lociii commented 10 years ago

The live indexer runs as a daemon by default. It will watch your library directory for changes and index new files / remove the ones you delete. The runserver command is Django specific. It starts a development webserver and is not meant to be used in production. You should use nginx + wsgi and something similar for production.

Indexing files without id3 tags is not that simple. The search on the web frontend and API only looks for information in the artist/title/etc. fields and not in the filename. Support for filename search would require heavy changes and may result in invalid results if the filename and id3 information differ.

parthlawate commented 10 years ago

Got it about nginx. Will give that a go over the next weekend ! About Indexing .. your are right ofcourse. I was just trying to make sure the music go it & could be played by browsing..

By the way we are thinking of creating a mini mobile app on top of this will keep you posted

lociii commented 10 years ago

Wow. That sounds cool. Thanks for the feedback. I'll close the issue.