search

locize / xliff

xliff2js and js2xliff converter xliff utils
MIT License
80 stars 37 forks source link

xliff to JSON functions should return #16

Closed irnnr closed 6 years ago

irnnr commented 6 years ago

A number of function already support returning their results instead of passing it to callbacks. However, the xliff to json functions - xliff12ToJs and xliffToJs - do not. I cannot see any async operations and would suggest to add the same pattern for these.

  if (cb) cb(null, result);
  return result;
adrai commented 6 years ago

You're right! v4.1.0

irnnr commented 6 years ago

That was quick, was going to do a PR, thanks a lot!