Expose noteKeys on createjs function

locize / xliff

xliff2js and js2xliff converter xliff utils

MIT License

80 stars 37 forks source link

Expose noteKeys on createjs function #46

Closed noelmugnier closed 3 years ago

noelmugnier commented 3 years ago

I've exposed the notesKeys (ntKeys) param to createjs function because i didn't figure out how to generate a js with notes without it :)

Checklist

[x] only relevant code is changed (make a diff before you submit the PR)
[x] run tests npm run test
[x] tests are included
[x] documentation is changed or added

adrai commented 3 years ago

Is there any particular reason why you're using the createJs function and not the xliff2js function https://github.com/locize/xliff/blob/master/test/test.js#L211 ?

adrai commented 3 years ago

rest lgtm

noelmugnier commented 3 years ago

Is there any particular reason why you're using the createJs function and not the xliff2js function https://github.com/locize/xliff/blob/master/test/test.js#L211 ?

Mainly because i don't start from xliff file, i'm building a svelte components parser which extract id|content|note from html tags. Then depending of user format i use createxliff12 or createjs to get a .xlf or .json file

adrai commented 3 years ago

Thank you for your contribution. It's included in v5.7.0