search

locka99 / opcua

A client and server implementation of the OPC UA specification written in Rust
Mozilla Public License 2.0
501 stars 131 forks source link

Session read with TimestampsToReturn::Both #140

Closed thosaa closed 2 years ago

thosaa commented 2 years ago

Doing a plain read will currently only return the server timestamp and not the source_timestamp.

https://github.com/locka99/opcua/blob/8cda7d236e422de1731f2997b0e3bc94d6fb4d56/client/src/session.rs#L1676-L1689

I suggest that the read either will default to get both timestamps, using: TimeestampsToReturn::Both or takes a 'timestamps_to_return' argument like history_read.

locka99 commented 2 years ago

I should just expose the TimestampsToReturn as an arg to this fn and let the caller supply the value

locka99 commented 2 years ago

Fixed on master branch

thosaa commented 2 years ago

Great! Thanks.