locka99 / opcua

A client and server implementation of the OPC UA specification written in Rust
Mozilla Public License 2.0
476 stars 129 forks source link

Fix a few clippy warnings #193

Closed lovasoa closed 2 years ago

lovasoa commented 2 years ago

There is no functional change, this only fixes a few clippy warnings, making the code a little bit more readable.

lovasoa commented 2 years ago

The failed tests are not linked to the contents of the pr

svanharmelen commented 2 years ago

Please note (to prevent double efforts) that PR #146 already fixes almost all clippy warnings.

lovasoa commented 2 years ago

@svanharmelen : Yes, I saw your pr, it looks great ! I really hope it will be merged someday, but it looks like it's going to take a lot of time. And I can't blame @locka99, I know how large PRs are hard to review, especially for a side project to which you cannot allocate a lot of time !

svanharmelen commented 2 years ago

Fair point...