search

locked-fg / JFeatureLib

Free Java library for image features and point/region detectors used in ComputerVision
38 stars 14 forks source link

Compilation Error #32

Closed cute-jumper closed 8 years ago

cute-jumper commented 8 years ago

The master branch can't be compiled successfully. The error is cause by https://github.com/locked-fg/JFeatureLib/blob/cf815a02c4376ce5e68f4862150c52e3df71271f/src/main/java/de/lmu/ifi/dbs/jfeaturelib/features/sift/SiftWrapper.java#L110 since waitFor() method accept no parameters instead of two.

cute-jumper commented 8 years ago

I found the cause... Java SE 8 does support waitFor() with two parameters. So I'm assuming Java 8 is essential for compiling this project?

locked-fg commented 8 years ago

Ahh thanks for pointing that out. the pom just says <maven.compiler.source>1.7</maven.compiler.source> <maven.compiler.target>1.7</maven.compiler.target>

This needs to be changed.

locked-fg commented 8 years ago

Raised compiler source/target to 1.8 in commit 8f1677705054d900124c75dbbc3aba6725c3b00f . This should fix this issue. Thanks again for reporting

cute-jumper commented 8 years ago

Thanks for the quick fix!