search

lockedata / starters

R Package 📦 for initializing projects for various R activities :nut_and_bolt:
https://itsalocke.com/starters/
GNU General Public License v3.0
124 stars 16 forks source link

package availability addressed #52

Closed taddallas closed 6 years ago

taddallas commented 6 years ago

Addressed name validation issue #38 by adding available functionality from R package available.

stephlocke commented 6 years ago

Thanks for a great PR @taddallas I appreciate you adding tests n all! I see a lot of repeated code on the available checks tho and I'm hoping you can abstract this into a util functions (and not exported) that can be used by everything. It may just need to be called from createBasicProject for the others to inherit the capability too saving much code!

taddallas commented 6 years ago

Thank you. The first pass was a bit inelegant, as I see now. I've added the function is_available which (I think) follows the naming conventions you've set up (correct me if I'm wrong), and haven't called it when it doesn't need to be called (e.g., in createAnalysisProject).

stephlocke commented 6 years ago

Thanks @taddallas for the great contribution!

We ship stickers to folks on a monthly basis, so if you'd like us to ship you a laptop sticker, go fill out https://airtable.com/tblYkXKrZmIVIxrqD/viwhMAgnbDW5nCRGx

stephlocke commented 6 years ago

D'oh - I gave you the wrong link! Sorry @taddallas https://airtable.com/shr31Z5XIyGbbwqFb

taddallas commented 6 years ago

:laughing: No worries. I was wondering why I needed to sign in and ask permission. Thanks for the cool sticker! And great work o the package as well.