lockedata / starters

R Package 📦 for initializing projects for various R activities :nut_and_bolt:

https://itsalocke.com/starters/

GNU General Public License v3.0

124 stars 16 forks source link

Issue #58 Make snake case name functions too #90

Closed sgetalbo closed 5 years ago

sgetalbo commented 5 years ago

create_any_project aesthetic function names added to the end of the four function scripts as per Steph's first comment.

codecov-io commented 5 years ago

Codecov Report

Merging #90 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   67.33%   67.33%           
=======================================
  Files          12       12           
  Lines         548      548           
=======================================
  Hits          369      369           
  Misses        179      179

Impacted Files	Coverage Δ
R/createTrainingProject.R	`97.56% <ø> (ø)`	:arrow_up:
R/createBasicProject.R	`100% <ø> (ø)`	:arrow_up:
R/createAnalysisProject.R	`100% <ø> (ø)`	:arrow_up:
R/createPackageProject.R	`86.2% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0fd68d...e9d83c5. Read the comment docs.

maelle commented 5 years ago

Can you please remove the DS_store files?
I don't see the Rd and NAMESPACE updates actually, did you forget to commit them?

sgetalbo commented 5 years ago

Hi @maelle - me and Steph fixed my git woes and I have removed the DS_store file and updated the master gitignore to include that so it won't crop up again. Also - .Rd files generated fine when I re-ran the devtools::document() command after I fixed my warnings, but even though I get a 'writing NAMESPACE' alert in my console, no new namespace file appears for me to push... any ideas?

maelle commented 5 years ago

:wave: here!

it seems there are a few conflicts. we can resolve the one for tests/README.md at the very end but for the other ones please try to solve them (maybe by merging master into your branch).
NAMESPACE was not updated. I think you need a @export roxygen2 tag before each new function, and then run document() again.
There are two .DS_store files to be deleted.

Thank you!

maelle commented 5 years ago

Thanks! Now the only issue is that there are two .DS_store files to be deleted.

maelle commented 5 years ago

@sgetalbo thanks! can you resolve the conflicts? after that the PR should be ready to be merged.