search

lockedata / starters

R Package 📦 for initializing projects for various R activities :nut_and_bolt:
https://itsalocke.com/starters/
GNU General Public License v3.0
124 stars 16 forks source link

Inconsistency with `reset` option #99

Closed jonmcalder closed 5 years ago

jonmcalder commented 5 years ago

Following the updates that were applied to address #66 (and probably even before that), the reset option has not been applied consistently.

The reset argument is present for createBasicProject(), createAnalysisProject() and createTrainingProject() (with a default value of TRUE in all cases).

However, this option has only actually been implemented and applied in the case of createBasicProject() - the only place it is required since this function is re-used by the others.

We should either remove the reset argument from createAnalysisProject() and createTrainingProject() or we should update these functions to adhere to the value set for this argument.

maelle commented 5 years ago

Good catch! Amy preferred option?

jonmcalder commented 5 years ago

To me it makes sense for all 4 functions to have the reset option as a common argument - with default TRUE. That way it's consistent and flexible but won't get in the way for anyone who doesn't want to use it.

maelle commented 5 years ago

Makes sense! Do you want to make a PR? 😸