search

locker-labs / locker-ui

https://app.locker.money
1 stars 0 forks source link

fix: expose locker agent address to client #14

Closed marvinmarnold closed 5 months ago

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
locker-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 11:58pm
marvinmarnold commented 5 months ago

@0xernesto are these changes necessary? Maybe it explains some of the problems you were having?

0xernesto commented 5 months ago

@0xernesto are these changes necessary? Maybe it explains some of the problems you were having?

The locker agent address was already exposed to the client. NEXT_PUBLIC is one way to do it, but can also expose without prepending that and specifying in next.config.js.

Don't think we're having any problems related to this at the moment.

marvinmarnold commented 5 months ago

@0xernesto are these changes necessary? Maybe it explains some of the problems you were having?

The locker agent address was already exposed to the client. NEXT_PUBLIC is one way to do it, but can also expose without prepending that and specifying in next.config.js.

Don't think we're having any problems related to this at the moment.

Ah thanks, I totally forgot we were doing that. Sorry in advance for a few NEXT_PUBLIC's I've scattered in at different places having forgotten in the past. I'll remove NEXT_PUBLIC_LOCKER_AGENT_ADDRESS from this PR.