PA Review: User Authentication

[lockjohn]

• [x] Backend: DB, model, controller, views
• [x] Redux Loop: ajax, actions, reducer
• [x] Presentational Components and Containers: login/signup, basic splash page structure
• [x] Styling to match clone
• [x] Demo User
• [x] Smooth, bug-free navigation
• [x] Adequate and appropriate seeds

[lockjohn]

I need to tweak the demo button so it works from both login and sign up page and need to fix the placeholder text.

[lockjohn]

• Pushed update to heroku that fixes above issues - though my demo button is taking two clicks. will circle back to this later.

[evhumphrey]

Nice job, looks awesome! I have some feedback:

• [x] Adjust the padding of your inputs; right now when you add text, it's up against the left edge of the input, which looks strange (hint: use box-sizing: border-box on session-form class, otherwise, adjusting the padding will cause your input fields to grow).
• [x] I would add a bit more spacing between the errors and the bottom input.
• [x] Don't use <br> tags to accomplish styling; this is an anti pattern. Instead, use margin top or bottom. This includes removing the one in between your buttons
• [ ] Two click demo issue (which you mentioned above)
• [x] I would your sign in nav div to an a tag instead, with the class nav-link. This will make it so you don't have to click on the text, but can click on the whole 'button'

Here's a screenshot for the form styling I mentioned:

[lockjohn]

When I try to wrap my component in an tag it gives me an error and says Link can't be a child of

Two click demo is hard to replicate, marking as complete 🎉