locks / ember-localstorage-adapter

Name says it all.
MIT License
466 stars 156 forks source link

Issue #221: Updated Dependencies and Test #222

Closed joestein216 closed 4 years ago

joestein216 commented 6 years ago

Fixes https://github.com/locks/ember-localstorage-adapter/issues/221.

jacobq commented 6 years ago

Just curious (I realize that this isn't what's currently breaking the build here), is the 05 problem because a leading 0 can indicate an octal literal? It seems that with the number 5 there shouldn't be any ambiguity.

jacobq commented 6 years ago

Hmm, why does this still appear to be using PhantomJS?

UPDATE: Aha, it looks like we need to remove this old testem.json.

jacobq commented 6 years ago

FWIW, I played with this a bit myself to get the tests passing again on https://github.com/locks/ember-localstorage-adapter/pull/223