search

locks / ember-localstorage-adapter

Name says it all.
MIT License
466 stars 156 forks source link

(Continuation of #222) #223

Closed jacobq closed 5 years ago

jacobq commented 6 years ago

Mostly I just want to see if the tests will pass again now that the testem.json file is removed. Feel free to close unmerged.

jacobq commented 6 years ago

Now it seems like the CI build is failing because something is trying to get ember via bower:

=== Scenario: ember-beta =======================================================

Missing npm packages: 
Package: ember-source
  * Specified: https://s3.amazonaws.com/builds.emberjs.com/beta/shas/84c8ecac85175571047690540f1dea7e62115c64.tgz
  * Installed: (not installed)

Run `npm install` to install missing dependencies.

Stack Trace and Error Report: /tmp/error.dump.0b0b8bf00cdce0c5b911a9a231e62703.log
An error occurred in the constructor for ember-cli-dependency-checker at /home/user/tmp/ember-localstorage-adapter/node_modules/ember-cli-dependency-checker

Result: false
---

Error!
Error: Cannot find module 'bower' from '/home/user/tmp/ember-localstorage-adapter/node_modules/ember-cli/bin'
Error: Cannot find module 'bower' from '/home/user/tmp/ember-localstorage-adapter/node_modules/ember-cli/bin'
    at Function.module.exports [as sync] (/home/user/tmp/ember-localstorage-adapter/node_modules/resolve/lib/sync.js:40:15)
    at CoreObject.module.exports.CoreObject.extend._resolveModule (/home/user/tmp/ember-localstorage-adapter/node_modules/ember-try/lib/dependency-manager-adapters/bower.js:203:20)
    at /home/user/tmp/ember-localstorage-adapter/node_modules/ember-try/lib/dependency-manager-adapters/bower.js:197:31
    at tryCatch (/home/user/tmp/ember-localstorage-adapter/node_modules/rsvp/dist/rsvp.js:525:12)
    at invokeCallback (/home/user/tmp/ember-localstorage-adapter/node_modules/rsvp/dist/rsvp.js:538:13)
    at publish (/home/user/tmp/ember-localstorage-adapter/node_modules/rsvp/dist/rsvp.js:508:7)
    at flush (/home/user/tmp/ember-localstorage-adapter/node_modules/rsvp/dist/rsvp.js:2415:5)
    at nextTickCallbackWith0Args (node.js:489:9)
    at process._tickCallback (node.js:418:13)
jacobq commented 6 years ago

Using npm@5 instead of npm@4 seems to fix the "Missing npm packages" part, and then I see 34/34 tests passing. What seems really weird to me though is that if I don't pass --skip-cleanup the error message about bower still shows up for some reason...maybe just leftover state in my dir? I'll try another commit w/ the npm change and see if it does the trick on CI.

Update: Seems like a fluke...now I can't get it to fail on my box with either npm 4 or 5 except when not passing --skip-cleanup

jacobq commented 5 years ago

Closing in favor of #225