This is first a tentative to speed up the loading of the 'Title Subscription Management' page by only loading the opened tabs.
This also introduce a 'Bulk Actions' feature to permit shift click to select multiple titles at the same time.
I've also changed the look and feel of the pages by re-using the CSS and JavaScript used on the 'Display Content Status'.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply
[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Feature modification (Fix or feature that will cause existing functionality to not work as expected)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] Rebase and squash my commits. Submit one commit only, on top of the master branch.
Further comments
Bulk action: At first I wasn't sure how to deal with the 'tristates' check-boxes so we've choose the 'bulk actions' approach but now I believe we could use the shift-click directly on the 'tristates' check-boxes. Also the 'Apply' button might be confusing as it only change the state of the 'tristates' check-boxes and doesn't actually submit the form.
Tabs: I've only made the changes on the 'Add Subscription' page as it seemed to be the one with loading issue.
Not being familiar with the whole project and wanting something done as soon as possible, I've tried to make as little modification to the code as possible by preserving old methods. However it might have been a better approach to review the whole process, by for example getting less data saved in the session and reducing the amount of data collected from the database.
Proposed changes
This is first a tentative to speed up the loading of the 'Title Subscription Management' page by only loading the opened tabs. This also introduce a 'Bulk Actions' feature to permit shift click to select multiple titles at the same time. I've also changed the look and feel of the pages by re-using the CSS and JavaScript used on the 'Display Content Status'.
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Reviewers: @tlipkis, @clairegriffin, ...
Thanks for your contribution.