loco-3d / crocoddyl

Crocoddyl is an optimal control library for robot control under contact sequence. Its solver is based on various efficient Differential Dynamic Programming (DDP)-like algorithms
BSD 3-Clause "New" or "Revised" License
806 stars 166 forks source link

Created a gait schedule and added a CoM task for the bipedal walking example - [merged] #485

Closed wxmerkt closed 4 years ago

wxmerkt commented 4 years ago

In GitLab by @cmastalli on Mar 15, 2019, 08:49

Merges topics/bipedal-walking -> devel

In this PR, I improved a bit the quality of the bipedal walking motion (you can see in this video https://youtu.be/MV6cB4V0GX4). The improvements are:

Please note that I have to modified the log file since the problem has been changed

wxmerkt commented 4 years ago

In GitLab by @nmansard on Mar 20, 2019, 08:06

no show please. Let the user control the windows.

wxmerkt commented 4 years ago

In GitLab by @nmansard on Mar 20, 2019, 08:08

Could you comment the following formula?

wxmerkt commented 4 years ago

In GitLab by @nmansard on Mar 20, 2019, 09:44

Thanks for the work. It is nice to have a nice-looking walk in crocoddyl. Yet this is pretty ad-hoc code, that we are likely not to exploit in the future. The cost design are vary naive compared to the HPP-Loco flow, and are likely very different to how we will use the memory. I believe we should not spend too much time on making these examples more complex.

wxmerkt commented 4 years ago

In GitLab by @cmastalli on Mar 20, 2019, 14:55

changed this line in version 2 of the diff

wxmerkt commented 4 years ago

In GitLab by @cmastalli on Mar 20, 2019, 14:55

changed this line in version 2 of the diff

wxmerkt commented 4 years ago

In GitLab by @cmastalli on Mar 20, 2019, 14:55

added 15 commits

Compare with previous version

wxmerkt commented 4 years ago

In GitLab by @cmastalli on Mar 20, 2019, 14:57

Now the user can control the rendering of windows. I follow the same standard defined in !142.

wxmerkt commented 4 years ago

In GitLab by @cmastalli on Mar 20, 2019, 14:58

I added an explanation of how it's defined the swing-leg reference motion. I also removed resKnots since it's an useless object which I committed by mistake.

wxmerkt commented 4 years ago

In GitLab by @cmastalli on Mar 20, 2019, 14:58

resolved all discussions

wxmerkt commented 4 years ago

In GitLab by @cmastalli on Mar 20, 2019, 15:10

Indeed, it doesn't follow the Loco3d flow. I did these changes for two reasons:

@nmansard -- You can merge it

wxmerkt commented 4 years ago

In GitLab by @nmansard on Mar 21, 2019, 09:22

mentioned in commit 3385da1df207aa21140fa13fbcc692fc3414efa7

wxmerkt commented 4 years ago

In GitLab by @nmansard on Mar 21, 2019, 09:22

merged