non-S3 hosting documentation contradics initializer

[kikito]

Step 8 on the following page gives incomplete instructions:

http://locomotivecms.com/support/installation/source

It says:

If you do not want to push the assets in S3 and instead leave them in your application, 
remove the lines about S3 in the config/assets.yml file and run the following command:

jammit --force

That is not enough. The code in config/initializer/carrierwave.rb will "default" to S3 anyway:

...
when :production
  if Locomotive.bushido?
    config.storage = :file
    config.root = File.join(Rails.root, 'public')
    config.store_dir = 'store'
  else
    config.storage = :s3
    config.s3_access_key_id = ENV['S3_KEY_ID']
    config.s3_secret_access_key = ENV['S3_SECRET_KEY']
    config.s3_bucket = ENV['S3_BUCKET']
    # config.s3_cname = 'ENV['S3_CNAME']
  end
end

This results in lots of ... interesting errors.

I see two possible ways to resolve this:

• Modify the documentation so that it includes a change in the carrierwave initializer or
• Modify the carrierwave initializer so that it the S3 variables are not set, the filesystem is used instead. (I believe this was the intended implementation)

Regards!

[did]

Hi Enrique,

Step 8 is not related to the carrierwave settings. But I do agree with you, it's confusing. Actually, I've to add another step explaining how to set up carrierwave if you want to choose the local filesystem instead. thanks !

Did

[did]

Done ! See https://github.com/locomotivecms/engine/commit/161878f57e3f9d66d6cf40471fbb32fd565bc08c I also updated the installation procedure. thanks again

Did

[kikito]

Sweet!