locomotivecms / engine

A platform to create, publish and edit sites
http://www.locomotivecms.com
Other
2.31k stars 626 forks source link

local_path => is already taken pushing images from wagon #824

Closed miletbaker closed 9 years ago

miletbaker commented 10 years ago

Hi,

I am having an issue pushing image assets from wagon. When trying to push images that contain either @2x in their filename, they upload fine on the first push but then on subsequent pushes the command line returns local_path => is already taken for these assets. I've also noticed the same issue if I create an additional folder in public that contains images, all of these return the same error.

I am assuming the logic for this is in the engine rather than Wagon itself, and wagon is just reporting the error back from the engine? If not I can reopen an issue on that repo.

Thanks.

miletbaker commented 10 years ago

Actually another issue is that is strips the @ from the filename breaking links. This is okay for my assets I can rename them but if I am including other js libraries with image assets for example this breaks them too. As @2x is a standard naming convention for retina images it would be great if Locomotive could support this naming convention.

Thanks

did commented 10 years ago

hi @miletbaker, it was related to Carrierwave which sanitizes the filename at the upload: https://github.com/carrierwaveuploader/carrierwave/issues/304.

ulitiy commented 10 years ago

I'm still having this issue on 2.4.1 engine and 1.4.0 wagon. Some name incompatibility between locomotive and filesystem? creating stylesheets/PIE.htc local_path => is already taken

yoshprogrammer commented 10 years ago

I'm still having this issue as well.

creating digital-signage/test_assets/bower_components/b[...]................ [error] local_path => is already taken

gregory commented 10 years ago

+1 with loco 2.5.5

did commented 10 years ago

guys, could you please try again with Wagon 1.5.0.rc1 and confirm me that bug is gone? thanks!

ExplodingCabbage commented 10 years ago

Today I played with both Rails and Locomotive for the first time. I'm using locomotive_cms (2.5.6) and locomotivecms_wagon (1.5.0) and observed this error. A little trial and error revealed that I consistently get this if any of my images have names that include normal parentheses () or colons :.

Removing those characters from image names fixed the issue for me.

Not sure how to install version 1.5.0.rc1 and don't have time to play about right now, but just thought I'd post this in case it's of any use either to @did in diagnosing this issue or to anybody looking for a workaround.

neversion commented 9 years ago

locomotive_cms(2.5.7) + locomotive_wagon(1.5.7) still got the error.

did commented 9 years ago

@neversion that's annoying. what's the local path of the failed file?

neversion commented 9 years ago

Once I there is file in directory expect fonts/images/javascripts/stylesheets/samples, I will got the error. In my case, it's plugins directory. Once I move plugins into javascripts, the error gone. 2015-10-07 1 59 55

did commented 9 years ago

@neversion are u using v3? If so, could you test with the last git commits of both Engine, Steam and Wagon please? thanks!

did commented 9 years ago

Alright, I was able to deploy/push images containing the "@2x" string with the last versions of Wagon/Engine. So, I'm closing the issue for now. If there are other failed cases, please re-open the issue.

neversion commented 9 years ago

@did sorry, I am using locomotive_cms(2.5.7) + locomotive_wagon(1.5.7).