Deprecated usage of Object#=~ might cause pbms with Mongo

locomotivecms / steam

The rendering stack used by both Wagon and Station (new name of the engine). It includes the rack stack and the liquid drops/filters/tags.

MIT License

38 stars 59 forks source link

Deprecated usage of Object#=~ might cause pbms with Mongo #190

Closed RobertDober closed 3 years ago

RobertDober commented 3 years ago

My local tests fail, need to make the PR to see what Travis says.

That said, seems a necessary fix for Ruby 2.7.*

did commented 3 years ago

hi @RobertDober! Glad to see you here ;-)

Interesting PR, it's safer indeed to use .to_s all the more since I've to upgrade to a newer version of Mongo (MongoDB, Mongoid, ..etc. Regarding your other issue (Travis secrets stuff), I've to look into it. thanks a lot!

RobertDober commented 3 years ago

@did it would not be my personal preference however there might be some pragmatic reasons I would be perfectly happy with and that's why I ask: Shall I try to get rid of more warnings in this PR or shall I open a different PR for this?

Depending on your answer this PR seems ready for review.