search

locomotivecms / wagon

Wagon is a command line tool that let's you develop for Locomotive right on your local machine.
https://www.locomotivecms.com
MIT License
188 stars 117 forks source link

Fix encoding issue #381

Closed eilers closed 4 years ago

eilers commented 4 years ago

I found a very strange problem if I used wagon sync on linux systems. This problem causes the following error message when using bundle exec wagon sync <environment>:

# Error description: invalid byte sequence in US-ASCII

I've found that the Tempfile is not running in binary mode as default! I don't know why this is the case, as it makes no sense in my opinion. You can read the following article for details:

http://vaidehijoshi.github.io/blog/2015/10/06/fleeting-filing-with-ruby-tempfile/

I've changed the call and .. voila .. it works now. :)

This "problem" seems to be linux related as it does not happen on a mac. You can use a ruby:2.6.3 docker container for testing.

eilers commented 4 years ago

@did Hi! I do not think that the failed build is related to my change. :)

did commented 4 years ago

@eilers hmm, could you work (rebase) from the master branch instead and see it fixes the specs? thanks!