search

locomotivemtl / locomotive-boilerplate

🚂 Front-end boilerplate for projects by Locomotive.
https://locomotivemtl-boilerplate.vercel.app/
MIT License
458 stars 71 forks source link

Replace ModularLoad with Barba #119

Open lucasvallenet opened 2 years ago

lucasvallenet commented 2 years ago

Remove modularload and use barba instead. It is located in the same module Load.js and uses the data-module-load namespace.

I also added a config.js file in the script root to have global vars (env, classnames, etc...) and updated the utils/environment.js with dom elements.

lucasvallenet commented 2 years ago

We won't merge the barba branch yet, but I think we could make use of the config.js already. Any idea on how to implement that, should I create a new pull request with this file only ?

mcaskill commented 2 years ago

We won't merge the barba branch yet, but I think we could make use of the config.js already. Any idea on how to implement that, should I create a new pull request with this file only ?

Yes, create a new pull request with only the changes to config.js (dom.js and environment.js, too?). Then this pull request can be rebased according to that and merged afterwards when ready.

lucasvallenet commented 2 years ago

We can maybe add these changed to PR#120 that is likely to be merged soon ?

arnvvd commented 1 year ago

Outcome from meeting on 2022-10-05 Status: On hold until further notice. We like the idea, but we need to do more tests before deciding if we use Barba.js. It depends on our current usage of modular load.