locomotivemtl / locomotive-boilerplate

🚂 Front-end boilerplate for projects by Locomotive.
https://locomotivemtl-boilerplate.vercel.app/
MIT License
455 stars 71 forks source link

Feature / CSS Variables #138

Closed lucasvallenet closed 1 year ago

lucasvallenet commented 1 year ago

Add default CSS variable settings that we use for several projects now.

Default grid settings and heading sizes.

I had to reorder the imports in the main.scss file in order to used some tools in the config file.

Located in /styles/settings/_config.variables.scss

lucasvallenet commented 1 year ago

My only suggestion would be to merge _config.scss and _config.variables.scss into one file.

I'd like to know what the others think. It's to dissociate the context between SCSS / CSS vars in two files, and also to avoid having the :root at the bottom of the file because of the use of SCSS vars

cloudflare-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 87238fc
Status: âœ…  Deploy successful!
Preview URL: https://883c3ba3.locomotive-boilerplate.pages.dev
Branch Preview URL: https://feature-css-variables.locomotive-boilerplate.pages.dev

View logs