search

loctvl842 / monokai-pro.nvim

Monokai Pro theme for Neovim written in Lua, with multiple filters: Pro, Classic, Machine, Octagon, Ristretto, Spectrum
MIT License
424 stars 40 forks source link

colourscheme override #110

Closed Red-M closed 6 months ago

Red-M commented 7 months ago

This should complete #106 Please let me know if anything needs to be done for this and I can add that as required.

I have tested this and it works as expected, one caveat is that changing filter or colorscheme will not necessarily change the colours as it is possible to change the base colours from this method.

Red-M commented 6 months ago

I've tested this further with my own fork to merge this and another MR I've submitted plus my own config and it works really well to allow me to override things in the theme without having to make changes upstream. This completely removes the need for me to maintain a fork to make changes and is much easier to deal with for everyone IMO.

loctvl842 commented 6 months ago

Thx a lot. Can you edit the monokai-pro/config.lua and README.md.

A clearer example showcasing the overrideScheme is preferable

Red-M commented 6 months ago

That should provide such an example, if an image is required, please let me know.

loctvl842 commented 6 months ago

That's nice. Thanks.