loctvl842 / monokai-pro.nvim

Monokai Pro theme for Neovim written in Lua, with multiple filters: Pro, Classic, Machine, Octagon, Ristretto, Spectrum
MIT License
424 stars 40 forks source link

Is this theme incompatible with latest NvChad? #83

Closed AnthonyCalandra closed 10 months ago

AnthonyCalandra commented 10 months ago

Hi there,

First time nvim user here. Saw this theme and thought it was the perfect Monokai Pro theme plugin! However, I installed this theme the other day and am having a few problems with it.

image

image

custom/chadrc.lua

M.ui = {
  theme = "monokai-pro",
  theme_toggle = { "monokai-pro", "one_light" },

  hl_override = highlights.override,
  hl_add = highlights.add,
}

custom/plugins.lua

  {
    "loctvl842/monokai-pro.nvim",
    lazy = false,
    priority = 1000,
    config = function()
      local monokai = require("monokai-pro")
      monokai.setup({
        transparent_background = false,
        terminal_colors = true,
        devicons = true, -- highlight the icons of `nvim-web-devicons`
        styles = {
          comment = { italic = true },
          keyword = { italic = true }, -- any other keyword
          type = { italic = true }, -- (preferred) int, long, char, etc
          storageclass = { italic = true }, -- static, register, volatile, etc
          structure = { italic = true }, -- struct, union, enum, etc
          parameter = { italic = true }, -- parameter pass in function
          annotation = { italic = true },
          tag_attribute = { italic = true }, -- attribute of tag in reactjs
        },
        filter = "pro", -- classic | octagon | pro | machine | ristretto | spectrum
        inc_search = "background", -- underline | background
        background_clear = {
          --"float_win",
          --"toggleterm",
          --"telescope",
          -- "which-key",
          --"renamer",
          --"notify",
          --"nvim-tree",
          -- "neo-tree",
          --"bufferline", -- better used if background of `neo-tree` or `nvim-tree` is cleared
        },-- "float_win", "toggleterm", "telescope", "which-key", "renamer", "neo-tree", "nvim-tree", "bufferline"
        plugins = {
          bufferline = {
            underline_selected = false,
            underline_visible = false,
          },
          indent_blankline = {
            context_highlight = "pro", -- default | pro
            context_start_underline = false,
          },
        },
        ---@param c Colorscheme
        override = function(c) end,
      })
      vim.cmd([[colorscheme monokai-pro]])
    end,
  },

There aren't instructions for lazy.nvim so I just took the packer example and ported that snippet to lazy. I didn't make any other modifications to the plugin itself. Will I need to port the plugin itself to make use of lazy properly? It seems like it sort of works so I'm not totally sure.

Thanks in advance! :)

loctvl842 commented 10 months ago

Sorry to say this, but I think NvChad override the theme. I never use NvChad before and I'm not intend to look into clearly (It would take me a lot of time to understand their logic).

My status bar has some icons that don't look quite right.

Have just take a look at NvChad, I think they customize their own bar that my theme doesn't support, you can check supported plugins.

The theme doesn't appear in the theme selection window

I think NvChad might override some Highlight Group. I try to make my theme works well with fresh installation of Telescope

AnthonyCalandra commented 10 months ago

Thank you for taking the time to look into it 🫡

I'll create a fork of your repo and see if I can make it work with NvChad 2 then. No promises. :)