fix(deployment): Only try to include SILO-specific config in the LAPIS/SILO configmap if it is actually defined

loculus-project / loculus

An open-source software package to power microbial genomic databases

https://loculus.org

GNU Affero General Public License v3.0

37 stars 2 forks source link

fix(deployment): Only try to include SILO-specific config in the LAPIS/SILO configmap if it is actually defined #2707

Closed theosanderson closed 2 months ago

theosanderson commented 2 months ago

resolves #2668

Previously failing to set silo: resulted in

which led LAPIS to crash

https://theosanderson-patch-7.loculus.org

corneliusroemer commented 2 months ago

I've tried this in the past and failed - maybe I just did something wrong. I'll add a preview.

theosanderson commented 2 months ago

I'm pretty sure this works, but even if it didn't it would be an improvement over the current state (it shouldn't be possible to get null in the yaml as occurs here) so it would be great to merge it