NCBI Ingest: Correct geolocation metadata mappings

loculus-project / loculus

An open-source software package to power microbial genomic databases

https://loculus.org

GNU Affero General Public License v3.0

37 stars 2 forks source link

Open anna-parker opened 2 months ago

anna-parker commented 2 months ago

[ ] #3105
[x] Additionally we map ncbiGeoRegion we map to geoLocAdmin2, which is not correct as ncbiGeoRegion corresponds to continent and geoLocAdmin2 should be "A local administrative region from which the sample was collected (ex: county or municipality)":
[ ] Can we reconsider the displayName for these fields? I think it will be confusing to submitters that geoLocAdmin1 gets mapped to collection subdivision etc.

corneliusroemer commented 2 months ago

Yeah this was on my list of things to fix/improve eventually. Thanks for making an issue.