search

loculus-project / loculus

An open-source software package to power microbial genomic databases
https://loculus.org
GNU Affero General Public License v3.0
37 stars 2 forks source link

Add pagination (or lazy load) to review page to a) load faster and b) reduce website memory requirements #2884

Closed corneliusroemer closed 4 weeks ago

corneliusroemer commented 1 month ago

Helps resolve #2881

We should add pagination to the review page results to not have to keep a large datastructure in website memory. Website should make paginated requests to db for the review results.

theosanderson commented 1 month ago

Yes - when I re-designed this page my idea was that there would simply be an endpoint that would return all the data needed to render one version of the page. There was resistance (or it was too much work) to doing this, but I think it may make sense to do the two things at once: stop the current lazy-loading whereby the actual information for each sequence card displayed is made in a separate query per card, and ensure proper pagination.

theosanderson commented 4 weeks ago

Closing in favour of #3031 if that's OK (with this issue still useful to capture the detail)