loculus-project / loculus

An open-source software package to power microbial genomic databases
https://loculus.org
GNU Affero General Public License v3.0
37 stars 2 forks source link

Make database secrets more consistent #2889

Open corneliusroemer opened 1 month ago

corneliusroemer commented 1 month ago

@anna-parker and I were looking into how to get the database name from the config. We were a bit confused that we currently specify secrets for keycloak-database and loculus-database in inconsistent ways:

  database:
    type: sealedsecret
    clusterWide: "true"
    encryptedData:
      host: AgDUG
      password: AgCm
      url: AgC
      username: AgAp
  keycloak-database:
    type: sealedsecret
    clusterWide: "true"
    encryptedData:
      addr: AgAw
      database: AgB
      password: AgDB
      port: Ag
      username: AgAuZZ

For more consistency we should

theosanderson commented 1 month ago

I wouldn't add unused fields: it's already a fair bit of effort to seal all the secrets. That doesn't stop you getting consistency, I expect, but it means you need to construct the URL from the address and the port, for example