search

loculus-project / loculus

An open-source software package to power microbial genomic databases
https://loculus.org
GNU Affero General Public License v3.0
37 stars 2 forks source link

chore: bump msw; switch to happy-dom for testing #3083

Closed fhennig closed 3 weeks ago

fhennig commented 4 weeks ago

resolves #3043

Summary

Bump to latest MSW version. Switch from jsdom to happy-dom.

We encountered a problem with the tests. An MSW maintainer helpfully investigated, and suggested to switch to happy-dom for the tests (https://github.com/mswjs/msw/issues/2273#issuecomment-2351508014) . I am doing this in this PR, and the tests work.

happy-dom is also faster than jsdom and we managed to get rid of a few workarounds that were needed with jsdom!

Screenshot

PR Checklist

fhennig commented 4 weeks ago

oops, sorry for merging main and not rebasing

fhennig commented 3 weeks ago

I removed jsdom and also 2 workarounds are not needed anymore, and I noticed that happy-dom is way faster at test execution! 🥳