loculus-project / loculus

An open-source software package to power microbial genomic databases
https://loculus.org
GNU Affero General Public License v3.0
37 stars 2 forks source link

feat(webpage, revision): Add an edit button to sequences that a user can revise #3092

Closed anna-parker closed 3 weeks ago

anna-parker commented 4 weeks ago

When users submit sequences - prior to approval - they can review the metadata and sequence that they uploaded via the webpage:

image

In this view users can update and revise the data that they uploaded.

We should add an edit button for each sequence that a user is allowed to revise that allows users to go back to this view. Button could be added here:

Screenshot 2024-10-28 at 18 03 18

The view should be populated with the current metadata fields (we need original and processed metadata for this), users should be able to edit the fields and then approve their changes - creating a new version of the sequence.

theosanderson commented 4 weeks ago

https://github.com/loculus-project/loculus/issues/3030 is a less well-specced version of this issue

theosanderson commented 4 weeks ago

the current metadata fields (we need original and processed metadata for this)

Do you have an idea for how we would present processed metadata here?

theosanderson commented 4 weeks ago

Well I guess we could just do whatever we currently do for the edit page for starters :)

theosanderson commented 4 weeks ago

Something to think about during this implementation: IMO the review page edit button should be changed to open the edit page in a modal rather than as its own page. (This is something we always planned but deprioritised). We don't have to do this now but when we are genericising the edit component it may make sense to make it a react component if it is not already to allow this.