fix(kubernetes): don't create `external_metadata_updater` user when `disableEnaSubmission`

loculus-project / loculus

An open-source software package to power microbial genomic databases

https://loculus.org

GNU Affero General Public License v3.0

37 stars 2 forks source link

fix(kubernetes): don't create `external_metadata_updater` user when `disableEnaSubmission` #3126

Closed fengelniederhammer closed 3 weeks ago

fengelniederhammer commented 3 weeks ago

preview URL:

Summary

If disableEnaSubmission: true, then I don't want to be forced to configure a externalMetadataUpdaterPassword

Screenshot

PR Checklist

~~- [ ] All necessary documentation has been adapted.~~ ~~- [ ] The implemented feature is covered by an appropriate test.~~

anna-parker commented 3 weeks ago

Just wanting to make sure this is documented here and not only on slack - we currently only use external_metadata_updater for the ena submission pod but it was written in a way that it could be used by other updater pods. So now it will require a template change if users want to add other pods like this.