https://github.com/loculus-project/loculus/pull/2352 added the option to set a versionComment field for revisions and revocations. However, as revocations do not have original metadata fields I had to add a new column just for the versionComment for revocations. The versionComment in revisions should just be treated as a normal metadata field. However, the field in the column and in the metadata need to be merged in get-released-data and here the contents of the versionComment column were overwriting the contents of the contents of the metadata field - this PR fixes the merge problem.
Screenshot
Revisions work again - can be made via page and show up:
Revocations also still work:
PR Checklist
[ ] All necessary documentation has been adapted.
[ ] The implemented feature is covered by an appropriate test.
theosanderson
commented
3 weeks ago
resolves #
preview URL: https://add-back-versioncomment.loculus.org/
Summary
https://github.com/loculus-project/loculus/pull/2352 added the option to set a versionComment field for revisions and revocations. However, as revocations do not have original metadata fields I had to add a new column just for the versionComment for revocations. The versionComment in revisions should just be treated as a normal metadata field. However, the field in the column and in the metadata need to be merged in get-released-data and here the contents of the versionComment column were overwriting the contents of the contents of the metadata field - this PR fixes the merge problem.
Screenshot
Revisions work again - can be made via page and show up:
Revocations also still work:
PR Checklist