search

loculus-project / loculus

An open-source software package to power microbial genomic databases
https://loculus.org
GNU Affero General Public License v3.0
37 stars 2 forks source link

Revoked sequences always have original submitter of the revoked version as the submitter, rather than the revoker #3244

Closed corneliusroemer closed 5 days ago

corneliusroemer commented 6 days ago

Just noticed that when I revoke an INSDC ingested sequence as a curator on staging ingest seems to auto approve the revocation. That's probably not what we want.

anna-parker commented 6 days ago

Just checked the staging DB and it looks like sequences that we revoked are listed as being revoked by he insdc_ingest_user: image

corneliusroemer commented 6 days ago

Interesting, that looks like a bug then! Revocation seems to have "submitter" set to the wrong account.

theosanderson commented 6 days ago

👍 I guess here it is just cloning the old submitter:

https://github.com/loculus-project/loculus/blob/a6b3bb77e7a61d49191eac042c8a541b6c35f667/backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt#L775