loculus-project / loculus

An open-source software package to power microbial genomic databases
https://loculus.org
GNU Affero General Public License v3.0
37 stars 2 forks source link

fix(backend): Fix submitter of revoked sequences to be the revoker #3246

Closed theosanderson closed 2 days ago

theosanderson commented 2 days ago

Fixes #3244

https://theosanderson-fix-revoked.loculus.org/

Update the submitter of a revoked sequence to the revoker

Tested that autoapprove no longer happens:

image

For more details, open the Copilot Workspace session.

corneliusroemer commented 2 days ago

Thanks! Oof, how did this live so long without us noticing 😬

corneliusroemer commented 2 days ago

I'm adding a test for this in #3248

corneliusroemer commented 2 days ago

@fengelniederhammer maybe you have some thoughts on how to better test the created sequence entries - we've now got a bunch of helpers, that's not terrible but maybe there's a neater way you know. Also, we might want to test similar basic things explicitly for other parts of the submission flow.

fengelniederhammer commented 2 days ago

we've now got a bunch of helpers

The helpers already look pretty helpful to me. The tests are nice to read.

corneliusroemer commented 2 days ago

@fengelniederhammer I just wasn't sure whether creating a helper for each property was a good way to go. Could come up with a better way (limited Kotlin knowledge).

corneliusroemer commented 2 days ago

Let's merge? @theosanderson :)