search

loculus-project / loculus

An open-source software package to power microbial genomic databases
https://loculus.org
GNU Affero General Public License v3.0
37 stars 2 forks source link

Delete-processed-tests #3258

Closed anna-parker closed 2 days ago

anna-parker commented 2 days ago

resolves #

preview URL:

Summary

Adds tests for https://github.com/loculus-project/loculus/pull/3252 to ensure we don't run into any pipeline update issues as in https://github.com/loculus-project/loculus/issues/3250 - I just verified that this test fails locally on main but now succeeds :-)

Failure on main:

DeleteAllSequenceDataEndpointTest > GIVEN preprocessing pipeline version 1 WHEN some sequences deleted THEN can update pipeline to version 2() FAILED
    java.lang.AssertionError: An update to v2 should be possible
    Expected: is <2L>
         but: was null

Screenshot

corneliusroemer commented 2 days ago

Nice! A good test of this test would be whether it fails on current main! You can just cherry pick and see that it fails. Maybe you've done that already but always good to test your test (expected fail)

corneliusroemer commented 2 days ago

This is great, can be reused for #3259