search

loculus-project / loculus

An open-source software package to power microbial genomic databases
https://loculus.org
GNU Affero General Public License v3.0
37 stars 2 forks source link

upgrade to Keycloakify 11 #3272

Open fhennig opened 20 hours ago

fhennig commented 20 hours ago

resolves #3264

preview URL: http://keycloakify-upgrade-try-a.loculus.org

Summary

Screenshot

TODO:

fhennig commented 20 hours ago

In 5e0c509 I'm applying the fix from @theosanderson from this PR: https://github.com/loculus-project/loculus/pull/3271

Weird that this just happens 'out-of-the-box' with the starter. Thanks again to @theosanderson for finding this!

fhennig commented 19 hours ago

It's working in the preview! 🥳

corneliusroemer commented 16 hours ago

After I found the root cause of the CI failure (wrong casing of kcContext that didn't show on macOS due to file system casing insensitivity) I wanted to report the issue to keycloakify but it turns out that the casing isn't in the starter: https://github.com/keycloakify/keycloakify-starter/blob/main/src/login/KcContext.ts

@fhennig how did you create the starter? Did you maybe not copy it over manually somehow rather than a complete removal over folder and replacement with current starter?

As a result, the fix is easier than Theo's which just happened to fix casing as well but the types extension was unnecessary.

fhennig commented 16 hours ago

What I did before was clone into keycloakify-starter, mv keycloakify keycloakify9 and mv keycloakify-starter keycloakify. I have no idea why the file was lowercase :O Well spotted! I thought I actually checked that as well, oh well.

I pushed the change now! It's actually good, because there is kc.gen.tsx which gets regenerated if the theme name changes and it contains a reference to KcContext, so it's nice that the file will be generated with the correct name.

Wow I feel stupid now 🤦 😅

theosanderson commented 16 hours ago

The file was named wrongly on main by me in the old version – now that it occurs to me I think I have dim memories of that. Some original eslint thing was giving me warnings and I briefly tried to fix them and then gave up or something

corneliusroemer commented 14 hours ago

You weren't stupid at all @fhennig - you actually did everything right and macOS (and git) played a trick on us! This is just something we need to remember can happen 🤷

corneliusroemer commented 14 hours ago

I've now added the keycloak update to 26, might as well test it with that.

corneliusroemer commented 13 hours ago

It's super confusing that version 26 is more like version 21 than 22-25 here: https://github.com/keycloakify/keycloakify/issues/731