search

locuslab / FLYP

Code for Finetune like you pretrain: Improved finetuning of zero-shot vision models
MIT License
87 stars 14 forks source link

Remove "noscale" argument #4

Open Haoxiang-Wang opened 1 year ago

Haoxiang-Wang commented 1 year ago

https://github.com/locuslab/FLYP/blob/61275a47af1cc10aa1398cfce2301e265af6f4c4/src/datasets/common.py#L142

It seems the noscale argument is useless in this codebase, and the non-existence of args.noscale incurs errors. So it's better to remove all occurrences of noscale and args.noscale in src/datasets/common.py.

SachinG007 commented 1 year ago

Hi @Haoxiang-Wang , Thanks a lot for pointing this out. noscale argument was for some experiments I was doing initially to compare normalizing features with not normalizing them. I will update the codebase and remove this argument.