search

locuslab / deq

[NeurIPS'19] Deep Equilibrium Models
MIT License
724 stars 80 forks source link

TrellisNetDEQModule class inheritence #8

Closed kevinliang888 closed 4 years ago

kevinliang888 commented 4 years ago

Hi, I noticed that in deq_trellisnet_module.py, you wrote

super(TransformerDEQModule, self).__init__(func, func_copy)

for class TrellisNetDEQModule. That not quite makes sense to me. Should that actually be following line instead? 

super(TrellisNetDEQModule, self).__init__(func, func_copy)`

Thanks for any clarification!

jerrybai1995 commented 4 years ago

Hi @kevinliang888 ,

Yes, thanks for pointing this out. Actually I should just put super().__init__(func, func_copy), but you are right that it should be TrellisNetDEQModule. I have fixed this and made a new push. 👍