search

locuslab / mpc.pytorch

A fast and differentiable model predictive control (MPC) solver for PyTorch.
https://locuslab.github.io/mpc.pytorch/
MIT License
872 stars 146 forks source link

fail to reproduce the example 'gym_pendulum_approximate.py' #29

Open lailaiflow opened 4 years ago

lailaiflow commented 4 years ago

Dear developers,

I tried to run the example 'gym_pendulum_approximate.py'. The solver did not manage to control the pendulum to the upright position as planned. The file was not modified at all. I assumed that you have testified it, just to make sure whether this is due to some mismatch in the versions of some python modules. Thanks.

July

bamos commented 4 years ago

Hi, that was an external contribution coming from #26 and I didn't test that code. Let me know if you find any other details out. If it's not working I'd be okay removing it from this repository to avoid confusion like this in the future

lailaiflow commented 4 years ago

thank you very much. i have noticed the implementation of LemonPi, pytorch_mppi which seems to solve the problem. I will try that asap.

best, lailai

On 7/28/20 10:03 PM, Brandon Amos wrote:

Hi, that was an external contribution coming from #26 https://github.com/locuslab/mpc.pytorch/pull/26 and I didn't test that code. Let me know if you find any other details out. If it's not working I'd be okay removing it from this repository to avoid confusion like this in the future

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/locuslab/mpc.pytorch/issues/29#issuecomment-665059145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGWDNDV3HTJUDVBYKXQA52LR53LBLANCNFSM4PKO7TJQ.