locuslab / tofu

Landing Page for TOFU
MIT License
84 stars 18 forks source link

Getting truth ratio always 1 #19

Open shaswati1 opened 6 months ago

shaswati1 commented 6 months ago

I am trying to reproduce the results in Figure 8 of the paper and getting the truth ratio as 1.0 for forget set (5%) for all the unlearning steps until 30. Can you please help me with this? @zhilif and @pratyushmaini

P.S. I'm using the new eval pipeline to generate the aggreate_stat.

zhilif commented 6 months ago

@shaswati1 Hi, can you post your a snippet of your aggregated_stat?

shaswati1 commented 6 months ago

Do you mean the aggreated_stat values? Sure, please take a look at the attached file. This is for 30th unlearning step! aggregate_stat.csv

zhilif commented 6 months ago

Can you send me the command that you use for unlearning and evaluation?

shaswati1 commented 6 months ago

I used the same commands that you provided in this link!

shaswati1 commented 6 months ago

@zhilif just to make sure, by command did you mean the configurations used for unlearning and evaluation?

zhilif commented 6 months ago

@zhilif just to make sure, by command did you mean the configurations used for unlearning and evaluation?

Right. So you used the default config and the command in README without modification?

shaswati1 commented 6 months ago

Yes, except for the precision. I'm using fp16 instead of bf16.

zhilif commented 6 months ago

Yes, except for the precision. I'm using fp16 instead of bf16.

Sorry for the late response, I was busy with some other stuff. The command in the current README looks like this python aggregate_eval_stat.py retain_result=${path_to_aggregated_retain_result} ckpt_result=${path_to_aggregated_retain_result} \ method_name=${method_name} save_file=${save_filename}, and I notice this typo that ${path_to_aggregated_retain_result} shows up twice. ckpt_result should take the path of ${path_to_aggregated_ckpt_result}. I apologize for this error. Can you try again and let me know if it works? Thanks!

shaswati1 commented 6 months ago

@zhilif, which json file should I refer to forckpt_result? This is not defined in the readme.

Carol-gutianle commented 3 months ago

I also have this problem and forget quality always 1.

Carol-gutianle commented 3 months ago

image Ok, I checked the function, perhaps ckpt_path refers to the retain version under the same settings.

jackwwy commented 1 month ago

waht is "path_to_aggregated_ckpt_result"

jackwwy commented 1 month ago

image Ok, I checked the function, perhaps ckpt_path refers to the retain version under the same settings.

so,Have you solved this problem