locusrobotics / qgis_ros

ROS QGIS Plugin prototype
MIT License
45 stars 9 forks source link

No topic selected error not handled in data_loader_widget #14

Open romainreignier opened 4 years ago

romainreignier commented 4 years ago

If one does not select a topic, the selected row is -1 and the .text() throws an exception here: https://github.com/locusrobotics/qgis_ros/blob/1789d5b973ea88952e914cebd30da615f7756655/src/qgis_ros/ui/data_loader_widget.py#L54-L55

There should be a check if row == -1 or catch the exception.

For now, the Add Layer button stays disabled and with the Loading... text on the bag dialog.

I am not a Python developer so I am not sure how to best catch the error.