locusrobotics / qgis_ros

ROS QGIS Plugin prototype
MIT License
45 stars 9 forks source link

Missing dependencies in QGIS-ROS #9

Open ablakey opened 5 years ago

ablakey commented 5 years ago

Hello @ablakey, I had the same issue with rospkg. After the pip3 install rospkg it was resolved, however there are other dependencies. Here is how I got it to stop generating errors on startup in Melodic:

pip3 install rospkg
pip3 install msgpack
pip3 install gnupg

Into my catkin ws:

git clone https://github.com/clearpathrobotics/wireless.git
git clone https://github.com/locusrobotics/json_transport.git

I think this raises two issues:

  1. There are unreported dependencies that I forgot about. These need to be, at the very least, listed.

  2. Some dependencies may be better off being optional. Sucks to have everyone install wireless for wireless_msgs if they might never use it. I should look into possibly importing these dependencies only at runtime if the translator gets used.

ablakey commented 5 years ago

I've temporarily updated requirements.txt and documentation. I want to do something better so I'll leave the ticket open, but hopefully it doesn't block others for now.

ablakey commented 5 years ago

Give this one a whirl: https://github.com/locusrobotics/qgis_ros/tree/ab-handle-empty-module-names