locusrobotics / robot_navigation

Spiritual successor to ros-planning/navigation.
450 stars 148 forks source link

Catkin_make CmakeLists.txt build issue #3

Closed WillGrayMSU closed 6 years ago

WillGrayMSU commented 6 years ago

I believe there may be an issue with the robot_navigation CMakeLists.txt that is causing the build to fail for catkin in ROS Kinetic. Firstly, the last package tag in CMakeLists.txt should be catkin_metapackage() Secondly, there are empty lines in the file that cause the build system to give this error:

CMake Error at /opt/ros/kinetic/share/catkin/cmake/catkin_workspace.cmake:95 (message): This workspace contains non-catkin packages in it, and catkin cannot build a non-homogeneous workspace without isolation. Try the 'catkin_make_isolated' command instead.

Currently the contents of the CMakeLists.txt in robot_navigation is: cmake_minimum_required(VERSION 2.8.3) project(robot_navigation)

find_package(catkin REQUIRED)

catkin_package()

When they should be: cmake_minimum_required(VERSION 2.8.3) project(robot_navigation) find_package(catkin REQUIRED) catkin_metapackage()

I have proposed a file change that fixed the build error for me.

DLu commented 6 years ago

Closed via #4