IPV6 check doesn't work as expected on AWS EKS

nc-marco commented 4 days ago

Prerequisites

[X] I am using the latest version of Locust
[X] I am reporting a bug, not asking a question

Description

In the current implementation, HAS_IPV6 is being used to determine if the host has an ipv6 stack and if it does, to use it. This unfortunately prevents locust.io from working in a standard EKS cluster in AWS. This is because though the container supports IPV6, the service resource in EKS does not support dual stack (as per documentation of AWS: https://docs.aws.amazon.com/eks/latest/userguide/cni-ipv6.html) and only supports IPV4 (or only IPV6 if you disable IPV4 which is of course not the default). Thus rpc between master and workers does not work. I removed the below lines from the code, rebuilt the container, and now it works. I would suggest, instead of the code trying to guess what stack to use, to actually be able to define it with an environmental variable.
Either way, even if this isn't deemed important enough to address, I leave this here so others can hopefully find this useful.

Command line

locust -f mylocustfile.py -

Locustfile contents

if HAS_IPV6:
            self.socket.setsockopt(zmq.IPV6, 1)

Python version

3.11.9

Locust version

2.29.1

Operating system

Linux 5.15.0-1056-aws

cyberw commented 4 days ago

That sounds really annoying! Either we can add a --ipv4 flag to force v4. But I'm thinking: Wouldnt the best be to open two ports? At least on the server side it should be easy (accept messages on both, respond on same). Client side might be sligthly more messy because we'd have to decide which one to send on.

Anyways, a PR for the above would be amazing, because I might not get around to it myself right now :)

nc-marco commented 3 days ago

Thanks for the quick response. I was talking to a colleague of mine today about the situation with other hyperscalers, in particular GKE. This supports a dual stack for the service resource just as it should. So my feeling is that this is a bit of an edge case where something like your first suggestion, that of just specifying an argument to force only ipv4, would be a reasonable solution. I mean, I labeled this as a bug, but it makes perfect sense to assume that if an OS supports dual stack then it should be able to communicate with the master with either of the two protocols and to default to ipv6. Furthermore, I don't see an elegant way to handle the client, as you pointed out, because it simply can't know until it tries and fails with ipv6.

So, if you are OK with this, I can create a small PR for just the simpler solution which would be appreciated probably only by those who need to run locust on EKS ;-).

locustio / locust