search

locustio / locust

Write scalable load tests in plain Python 🚗💨
https://locust.cloud
MIT License
25.11k stars 3k forks source link

Update ruff mypy #2978

Closed tdadela closed 2 weeks ago

tdadela commented 2 weeks ago

Unpin poetry: ruff is pinned to one particular version to keep the same version as in .pre-commit-config.yaml. I don't see reasons for poetry to be pinned. (Especially since adding poetry.lock file to the repo). Bump ruff: there were a lot of improvements over the last half year (including better detection of old style string interpolation #2974).

cyberw commented 2 weeks ago

Pinning ruff/mypy was because new versions of those can cause a new build to fail with no source change. But its probably a smaller issue than accidentally having really old versions..

tdadela commented 2 weeks ago

Makes sense. Just to clarify and be sure that we are on the same: poetry install uses the exact versions from poetry.lock. So someone will install newer version of mypy only if that person intentionally execute poetry update (or add new dependency or execute other similar command).