Closed digitaldonkey closed 8 years ago
Hi, have you considered upgrading to Locutus?
Actually I have no clue. Just want my theme to get installed without warnings. phpjs is part of kss-node. https://github.com/kss-node/kss-node/issues/326
omg. The 1.3.2 version of phpjs on npm is deeply flawed.
"dependencies": {
"cli": "0.4.4-2",
"deep-equal": "0.1.2",
"glob": "3.2.1",
"js-beautify": "1.4.2",
"mocha": "1.17.0",
"send": "0.1.0",
"underscore": "1.5.2"
},
No node.js library should ever have mocha as a dependency; it is a test runner that should be a dev dependency. It looks like the git repository for phpjs library has been replaced with this one (locutus), but does not contain any of the original code. (locutus 1.3.2 !== phpjs 1.3.2.) So it's impossible to even fix the problem.
This issue can be closed. Twig.js will switch to locutus since it is just using a couple of the files.
@JohnAlbin Thanks. Good thing that you are switching to Locutus, devDependencies were hardly the only thing flawed with php.js. If you really want to know, there's more background here http://locutus.io/2016/05/announcing-locutus/
Description
Installing npm dependencies it seems that phpjs 1.3.2 uses some very outdated packaged, causing warnings:
There are updates available:
https://github.com/isaacs/node-glob/tree/v7.0.3 https://github.com/mochajs/mocha/tree/v2.5.3