Support explicit, terminated chain sequences.

lodash / babel-plugin-lodash

Modular Lodash builds without the hassle.

Other

1.96k stars 92 forks source link

Support explicit, terminated chain sequences. #176

Closed m-orchard closed 6 years ago

m-orchard commented 7 years ago

This does some work towards #92 - I've not had time yet to figure out if or how unterminated chains might be handled, as well as imlpicit chains.

Would be good to know if this is something you'd be willing to merge, I know you said you would accept a PR on #92 but obviously this doesn't cover all cases, at least yet.

If you do have thoughts on how unterminated and implicit chains could be handled, I'd be glad to hear them and see if I can make any more progress.

jsf-clabot commented 7 years ago

All committers have signed the CLA.

jdalton commented 7 years ago

Whoa! So awesome! 🎉

lukeapage commented 7 years ago

I'd be happy to see this merged as is, we could start using the plugin but we would enforce no unterminated or implicit chaining.

Does it need rebasing? Looks like it picked up unintentional commits.

m-orchard commented 7 years ago

Ah yes, will rebase!

m-orchard commented 7 years ago

Rebased

lukeapage commented 7 years ago

@jdalton any chance of getting this merged or reviewed soon?

jdalton commented 7 years ago

Hi @lukeapage!

I have my head down with the WIP esm loader at the moment.

adierkens commented 6 years ago

Any update on this?

laander commented 6 years ago

Bump on this, would be amazeballs to get out! ⚡️

rkrueger11 commented 6 years ago

what about now? 😁

m-orchard commented 6 years ago

@jdalton I've pushed an up-to-date version of this. I noticed you've updated your code style - I tried to bring my changes inline with that, so let me know if there's anything I've missed!

jdalton commented 6 years ago

@mickylad Thank you! Yeah, my code style tends to change based on the last project I worked on. There is now a clash of styles I'll be dealing with 😋

jdalton commented 6 years ago

🎉 🎉 :tada:

m-orchard commented 6 years ago

I know the feeling! Thanks! :)

hipstersmoothie commented 6 years ago

Can we get a release?

hipstersmoothie commented 6 years ago

are we gonna get a release in 2018? @mickylad @jdalton @anyone-who-cares

lukeapage commented 6 years ago

I care.. am waiting to use it, though if I get the time I will just publish it privately, so this is an annoyance but not a blocker.

alisowski54 commented 6 years ago

@lukeapage @mickylad @laander @rkrueger11 PR was reverted :(

jdalton commented 6 years ago

Even thought it was ultimately reverted I'm very thankful to @mickylad for putting the time into this and its follow-up PR!